Skip to content

OLS-1980: Add autodiscovery for indexID value #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

OLS-1980: Add autodiscovery for indexID value #1032

merged 1 commit into from
Oct 31, 2025

Conversation

@syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 6, 2025

Description

This PR makes the default value of the RAG indexID an empty string, which makes it unnecessary to know the exact value of the index ID the Faiss RAG database was built with.
This PR depends on openshift/lightspeed-service#2626.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2025 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1980 which is a valid jira issue.

In response to this:

Description

This PR makes the default value of the RAG indexID an empty string, which makes it unnecessary to know the exact value of the index ID the Faiss RAG database was built with.
This PR depends on openshift/lightspeed-service#2626.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from raptorsun and xrajesh October 6, 2025 22:43
@syedriko syedriko marked this pull request as draft October 6, 2025 22:44
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2025
@syedriko
Copy link
Contributor Author

syedriko commented Oct 6, 2025

/retest

@syedriko syedriko marked this pull request as ready for review October 7, 2025 03:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
@openshift-ci openshift-ci bot requested a review from bparees October 7, 2025 03:30
raptorsun
raptorsun reviewed Oct 10, 2025
View reviewed changes
test/e2e/byok_test.go
}}
err := env.Client.Get(olsConfig)
Expect(err).NotTo(HaveOccurred())
Expect(olsConfig.Spec.OLSConfig.RAG[0].IndexID).To(BeEmpty())
Copy link
Contributor

@raptorsun raptorsun Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing:

BYOK [It] should check that the default index ID is empty [BYOK]
/go/src/github.com/openshift/lightspeed-operator/test/e2e/byok_test.go:36
  [FAILED] Expected
      <string>: vector_db_index
  to be empty
  In [It] at: /go/src/github.com/openshift/lightspeed-operator/test/e2e/byok_test.go:43 @ 10/08/25 05:42:53.317

Copy link
Contributor Author

@syedriko syedriko Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @raptorsun, I've updated the bundle.

Copy link
Contributor Author

@syedriko syedriko Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raptorsun Updating the bundle was not enough, the PR needs openshift/lightspeed-service#2626 to be merged.

@xrajesh
Copy link
Contributor

xrajesh commented Oct 14, 2025

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2025
@syedriko
Copy link
Contributor Author

syedriko commented Oct 14, 2025

/retest

@raptorsun
Copy link
Contributor

raptorsun commented Oct 16, 2025

operator image upated, please rebase and rerun the e2e tests

@syedriko
Copy link
Contributor Author

syedriko commented Oct 17, 2025

operator image upated, please rebase and rerun the e2e tests

We need to merge openshift/lightspeed-service#2626 first.

@syedriko
Copy link
Contributor Author

syedriko commented Oct 17, 2025

/retest

3 similar comments
@syedriko
Copy link
Contributor Author

syedriko commented Oct 21, 2025

/retest

@syedriko
Copy link
Contributor Author

syedriko commented Oct 21, 2025

/retest

@syedriko
Copy link
Contributor Author

syedriko commented Oct 22, 2025

/retest

@raptorsun
Copy link
Contributor

raptorsun commented Oct 22, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@syedriko
Copy link
Contributor Author

syedriko commented Oct 26, 2025

/test bundle-e2e-4-19

@syedriko
Copy link
Contributor Author

syedriko commented Oct 27, 2025

/retest

@syedriko
Copy link
Contributor Author

syedriko commented Oct 27, 2025

/test bundle-e2e-4-19

@raptorsun
Copy link
Contributor

raptorsun commented Oct 30, 2025

/retest

@raptorsun
Copy link
Contributor

raptorsun commented Oct 31, 2025

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2025

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e5e1454 into openshift:main Oct 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrajesh xrajesh Awaiting requested review from xrajesh

@bparees bparees Awaiting requested review from bparees

1 more reviewer

@raptorsun raptorsun raptorsun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@raptorsun raptorsun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syedriko @openshift-ci-robot @xrajesh @raptorsun